[ 
https://issues.apache.org/jira/browse/MJARSIGNER-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837013#comment-17837013
 ] 

ASF GitHub Bot commented on MJARSIGNER-76:
------------------------------------------

Marcono1234 opened a new pull request, #20:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/20

   Note that I am also the author of the Jira ticket. So no worries if you 
don't think this is useful for enough users, or if you want to wait until other 
users request this change too.
   
   Note completely sure why the plugin wasn't printing the file paths before.
   - It is probably not that verbose, assuming users normally only use 
Jarsigner on a few files.
   - The file paths are probably also not a secret, so printing them does not 
leak any information.




> Print names of processed files
> ------------------------------
>
>                 Key: MJARSIGNER-76
>                 URL: https://issues.apache.org/jira/browse/MJARSIGNER-76
>             Project: Maven Jar Signer Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Marcono1234
>            Priority: Minor
>
> h2. Problem
> Currently the plugin just prints the number of processed artifacts once it is 
> done, for example:
> {quote}
> 2 archive(s) processed
> {quote}
> This has these disadvantages:
> - It is not immediately obvious if the intended file has been signed (e.g. 
> when using wildcards)
> - If the number is higher than expected, it is not obvious which additional 
> files were signed redundantly
> In both cases it is necessary to manually inspect the artifacts of the 
> project and check if they have been signed (or use {{jarsigner}} to verify 
> them).
> h2. Improvement
> By default the plugin should print the file names of the signed artifacts. 
> This information is already available in {{AbstractJarsignerMojo#execute}}, 
> but currently only {{archives.size()}} is logged.
> - Ideally each file should be logged in a separate line to be easier to read.
> - The relative file path (and not only the file name) should be logged. 
> Otherwise there might be confusion if the same file exists in multiple 
> directories, e.g. if it is copied by another plugin during the build.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to