[
https://issues.apache.org/jira/browse/MWRAPPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837827#comment-17837827
]
ASF GitHub Bot commented on MWRAPPER-128:
-----------------------------------------
slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-wrapper/pull/126#discussion_r1567788687
##########
maven-wrapper-plugin/pom.xml:
##########
@@ -34,7 +34,7 @@ under the License.
<description>The Maven Wrapper Plugin is a plugin that provides support for
the Maven Wrapper by unpacking Maven Wrapper Distribution to the current
project.</description>
<prerequisites>
- <maven>${mavenVersion}</maven>
+ <maven>3.2.5</maven>
Review Comment:
I'm still not sure about it ... when we depend on newer version we can have
some issues in runtime which is not cover by ITs.
But from other side we have more information about depractions ...
The perfect way will be for me depends on the same version as in in
prerequisites ... but we block using plugin for older Maven ....
So we need a compromise on it 😄
> Remove legacy
> -------------
>
> Key: MWRAPPER-128
> URL: https://issues.apache.org/jira/browse/MWRAPPER-128
> Project: Maven Wrapper
> Issue Type: Task
> Components: Maven Wrapper Plugin
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.3.0
>
>
> This plugin still uses legacy stuff: zap it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
