[
https://issues.apache.org/jira/browse/MWRAPPER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839808#comment-17839808
]
Rocher Suchard edited comment on MWRAPPER-133 at 4/22/24 6:16 PM:
------------------------------------------------------------------
[~sjaranowski] I don't know the history behind Jenkins Maven Pipeline and Maven
Wrapper but the MAVEN_CONFIG is not something from Maven, but something found
in the wrapper script directly (I do not check the cmd part because even as a
Windows user, I loath to use batch and cmd file :)) :
{code:bash|title=mvn wrapper:3.2.0:wrapper -Dmaven=3.9.6 -Dtype=bin}
# shellcheck disable=SC2086 # safe args
exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" \
"-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \
${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@"
{code}
versus
{code:bash|title=mvn wrapper:3.3.0:wrapper -Dmaven=3.9.6}
exec_maven() {
unset MVNW_VERBOSE MVNW_USERNAME MVNW_PASSWORD MVNW_REPOURL || :
exec "$MAVEN_HOME/bin/$MVN_CMD" "$@" || die "cannot exec
$MAVEN_HOME/bin/$MVN_CMD"
}
{code}
As show above, {{$MAVEN_CONFIG}} is not there but it is present in the wrapper
script in 3.2.0 :
{code:bash|title=mvn wrapper:3.2.0:wrapper -Dmaven=3.9.6 -Dtype=script}
# shellcheck disable=SC2086 # safe args
exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" \
"-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \
${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@"
{code}
If there is a maven alternative (MAVEN_ARGS) why not, but from user standpoint,
removing MAVEN_CONFIG is forcing user to
1) either stay with maven wrapper 3.2.0
2) either upgrade Jenkins or its maven pipeline (or other kind of pipeline) =
complicated.
was (Author: rocher.suchard):
[~sjaranowski] I don't know the history behind Jenkins Maven Pipeline and Maven
Wrapper but the MAVEN_CONFIG is not something from Maven, but something found
in the wrapper script directly (I do not check the cmd part because even as a
Windows user, I loath to use batch and cmd file :)) :
{code:bash|title=mvn wrapper:3.2.0:wrapper -Dmaven=3.9.6 -Dtype=bin}
# shellcheck disable=SC2086 # safe args
exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" \
"-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \
${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@"
{code}
versus
{code:bash|title=mvn wrapper:3.3.0:wrapper -Dmaven=3.9.6}
exec_maven() {
unset MVNW_VERBOSE MVNW_USERNAME MVNW_PASSWORD MVNW_REPOURL || :
exec "$MAVEN_HOME/bin/$MVN_CMD" "$@" || die "cannot exec
$MAVEN_HOME/bin/$MVN_CMD"
}
{code}
The {{$MAVEN_CONFIG}} is not there but it is present in the wrapper script in
3.2.0 :
{code:bash|title=mvn wrapper:3.2.0:wrapper -Dmaven=3.9.6 -Dtype=script}
# shellcheck disable=SC2086 # safe args
exec "$JAVACMD" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
-classpath "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" \
"-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \
${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@"
{code}
If there is a maven alternative (MAVEN_ARGS) why not, but from user standpoint,
removing MAVEN_CONFIG is forcing user to
1) either stay with maven wrapper 3.2.0
2) either upgrade Jenkins or its maven pipeline (or other kind of pipeline) =
complicated.
> MAVEN_CONFIG populated by Jenkins Maven Pipeline is no longer read,
> -------------------------------------------------------------------
>
> Key: MWRAPPER-133
> URL: https://issues.apache.org/jira/browse/MWRAPPER-133
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
> Affects Versions: 3.3.0
> Reporter: Rocher Suchard
> Priority: Major
>
> Hello,
> Due to an update by Renovate in one of our project, I've seen some error
> related to internal dependencies not being picked up by Maven : while we were
> using a custom settings, it did not use it and was using Central instead of
> our Artifactory.
> Upon analysis, it seems that Maven Pipeline define a MAVEN_CONFIG
> environnement variable here :
> https://github.com/jenkinsci/pipeline-maven-plugin/blob/8cfaff9c021c971d19e5469c553a86d954c05387/pipeline-maven/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution2.java#L400
> The MAVEN_CONFIG variables was used in our Maven 3.2.0 Wrapper script and
> I've played around with the default value and type:
> {code:bash}
> $ mvn wrapper:3.3.0:wrapper -Dmaven=3.9.6
> # use scripts-only
> $ grep -r MAVEN_CONFIG mvnw mvnw.cmd .mvn/
> # nothing
> $ mvn wrapper:3.2.0:wrapper -Dmaven=3.9.6
> # use bin
> $ grep -r MAVEN_CONFIG mvnw mvnw.cmd .mvn/
> mvnw:MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $*"
> mvnw: ${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@"
> mvnw.cmd: %WRAPPER_LAUNCHER% %MAVEN_CONFIG% %
> $ mvn wrapper:3.3.0:wrapper -Dmaven=3.9.6 -Dtype=bin
> ...
> [INFO] Unpacked bin type wrapper distribution
> org.apache.maven.wrapper:maven-wrapper-distribution:zip:bin:3.3.0
> [INFO] Configuring .mvn/wrapper/maven-wrapper.properties to use Maven 3.9.6
> and download from https://repo.maven.apache.org/maven2
> ...
> $ grep -r MAVEN_CONFIG mvnw mvnw.cmd .mvn/
> mvnw:MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $*"
> mvnw: ${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@"
> mvnw.cmd: %WRAPPER_LAUNCHER% %MAVEN_CONFIG% %*
> {code}
> Is there a way to do the same for the script-only if this is to be the
> default ?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
