[ https://issues.apache.org/jira/browse/NIFI-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127794#comment-16127794 ]
ASF GitHub Bot commented on NIFI-4242: -------------------------------------- GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/2088 NIFI-4242 Allow quote and escape chars for CSV to be 'undefined'. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [✓] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [✓] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [✓] Has your PR been rebased against the latest commit within the target branch (typically master)? - [✓] Is your initial contribution a single, squashed commit? ### For code changes: - [✓] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [✓] Have you written or updated unit tests to verify your changes? - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [N/A] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Wesley-Lawrence/nifi NIFI-4242 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2088.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2088 ---- commit fbe8ad616297f7a6bf0b17039c9448fb2ac1514c Author: Wesley-Lawrence <wesleyll...@gmail.com> Date: 2017-08-15T19:28:09Z NIFI-4242 Allow quote and escape chars for CSV to be 'undefined'. ---- > CSVReader shouldn't require that an escape character be defined > --------------------------------------------------------------- > > Key: NIFI-4242 > URL: https://issues.apache.org/jira/browse/NIFI-4242 > Project: Apache NiFi > Issue Type: Bug > Affects Versions: 1.3.0 > Reporter: Wesley L Lawrence > Priority: Minor > Attachments: NIFI-4242.patch, NIFI-4242.patch > > > There are situations where, when parsing a CSV file, one doesn't want to > define an escape character. For example, when using quote character ", the > following is valid CSV; > {code} > a,"""b",c > {code} > The second column should be interpreted as "b. But when Apache Commons CSV is > told that there's an escape character, the above row is invalid > (interestingly, if it was """b""", it would be valid as "b"). > There are known formats that Apache Commons CSV provides, that doesn't define > escape characters either. -- This message was sent by Atlassian JIRA (v6.4.14#64029)