JingsongLi commented on code in PR #1140:
URL: https://github.com/apache/incubator-paimon/pull/1140#discussion_r1192000505


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/Expression.java:
##########
@@ -61,21 +63,55 @@ static Expression year(String fieldReference) {
         return new YearComputer(fieldReference);
     }
 
-    /** Compute year from a time input. */
-    final class YearComputer implements Expression {
-
-        private static final long serialVersionUID = 1L;
+    static Expression substring(String fieldReference, String... literals) {
+        checkArgument(
+                literals.length == 2,

Review Comment:
   support `substring(int beginIndex)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to