JingsongLi commented on code in PR #4034:
URL: https://github.com/apache/paimon/pull/4034#discussion_r1726735219
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreWrite.java:
##########
@@ -104,6 +105,17 @@ default FileStoreWrite<T> withMemoryPool(MemorySegmentPool
memoryPool) {
*/
void write(BinaryRow partition, int bucket, T data) throws Exception;
+ /**
+ * Write the batch data to the store according to the partition and bucket.
+ *
+ * @param partition the partition of the data
+ * @param bucket the bucket id of the data
+ * @param data the given data
+ * @return whether success to write batch
+ * @throws Exception the thrown exception when writing the record
+ */
+ boolean writeBatch(BinaryRow partition, int bucket, BatchRecords data)
throws Exception;
Review Comment:
we don't need to return boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
