[ 
https://issues.apache.org/jira/browse/SOLR-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813706#comment-17813706
 ] 

David Smiley edited comment on SOLR-17147 at 2/2/24 3:00 PM:
-------------------------------------------------------------

Why can't we use "commit" and also have it default to true?

I don't think anyone is likely to specify commitWithin with this tool but if I 
recall users +can+ add arbitrary parameters if they so choose?


was (Author: dsmiley):
Why can't we use "commit" and also have it default to true?

I don't think anyone is likely to specify commitWithin with this tool but if I 
recall users can't add arbitrary parameters if they so choose?

> To commit or not to commit?  That is the question on bin/solr post
> ------------------------------------------------------------------
>
>                 Key: SOLR-17147
>                 URL: https://issues.apache.org/jira/browse/SOLR-17147
>             Project: Solr
>          Issue Type: Sub-task
>          Components: cli
>    Affects Versions: 9.5
>            Reporter: Eric Pugh
>            Assignee: Eric Pugh
>            Priority: Minor
>
> The way we have set up most boolean options in the bin/solr is that you 
> specific the option to mean "true".   Versus doing a "option=true" or 
> "option=false".    In the bin/post command, the commit is a explicit 
> true/false, and if you don't specifiy it, then there is automatically a 
> commit.   However, with bin/solr post, if you don't specify -commit, then you 
> don't get a commit.   
> Which makes sense from how the options are laid out "yes I want to opt into a 
> commit", however I suspect the vast majority of users who use the command 
> will immediatly go look for the doc, and wonder why it isn't visible..  which 
> is proably why bin/post commits if you don't specify it.
> Our options are to have an explicit -commit=true/false OR we commit by 
> default and have a -nocommit option.   
> I guess I am leaning towards having a -nocommit as a boolean option, so that 
> wihtout it you get the commit...   
> Fortunantly optimize story is better.  by default we do NOT issue an 
> optimize, but you can do -optimize to requiest that ;-).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to