[ https://issues.apache.org/jira/browse/SOLR-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845130#comment-17845130 ]
David Smiley commented on SOLR-16924: ------------------------------------- > (Funnily enough, this is actually an idea I got from you! I'll add the link > in here if I can dig it up...) Yes I do remember now :) it makes sense. It'd be helpful if classes distinctly "V1" had javadocs saying so. I'll move the logic. Probably not worth a JIRA. When I see a package "handler", I'm thinking request handlers, thus API (and may include implementation). Even the package-info.java says it's for SolrRequestHandlers. But this class doesn't end in Handler so okay, it's not a handler. I'm good with it. > Restore: Have RESTORECORE set the UpdateLog state > -------------------------------------------------- > > Key: SOLR-16924 > URL: https://issues.apache.org/jira/browse/SOLR-16924 > Project: Solr > Issue Type: Improvement > Reporter: David Smiley > Priority: Minor > Fix For: 9.5 > > Time Spent: 50m > Remaining Estimate: 0h > > This is a refactoring improvement designed to simplify & clarify a step in > collection restores. One of the final phases of RestoreCmd (collection > restore) is to call REQUESTAPPLYUPDATES on each newly restored replica in > order to transition the state of the UpdateLog to ACTIVE (not actually to > apply updates). The underlying call on the UpdateLog could instead be done > inside RESTORECORE at the end with explanatory comments as to the intent. I > think this makes more sense that RESTORECORE finish with its UpdateLog ready. > And it's strange/curious to see requests in the cluster to apply updates > from an updateLog when there is none to do! Adding clarifying comments is > important. > See my comment: > https://issues.apache.org/jira/browse/SOLR-12065?focusedCommentId=17751792&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17751792 > I think there isn't any back-compat concern. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org