On Fri, 15 Apr 2005, Chris Kennedy wrote:
> This fixes yuv_fixup to always be an available option to the module and also
> to actually work on compilation again when enabled.  It has some small fixes
> to the start capture of VBI, fixes it again for pvr250 cards when sliced,
> had broken it.  Also the line at the bottom of the pvr150 is no longer there
> from the VSCALE fix on the list...
>
> #0.3.2y: http://www.ivtv.tv/

Thank you so much, Chris, I'll try it out a bit later tonight.

However, if you don't mind, may I offer some additional info?

Looking over the diff, I see you commented out the set_vscale call
under certain circumstances (as per other posts here):

------

--- ivtv-0.3.2x/driver/cx25840-driver.c 2005-04-14 10:30:40.000000000 -0500
+++ ivtv-0.3.2y/driver/cx25840-driver.c 2005-04-15 15:06:40.000000000 -0500
@@ -871,7 +871,7 @@
                CX25840_SET_VS_INTRLACE(1);
                CX25840_SET_VFILT(filter);
                CX25840_SET_HSCALE(HSC);
-               CX25840_SET_VSCALE(VSC);
+               //CX25840_SET_VSCALE(VSC);
                break;
        }

------

While that will cure the symptom (and my dmesg output indicates that the
related print statement never occurs until changing to the tuner so it's
also relatively safe), I believe the cause of the problem is elsewhere.
An excerpt from my knoppmyth forum post dmesg output, with unimportant
lines removed:

http://mysettopbox.tv/phpBB2/viewtopic.php?t=4170

------

PVR-350 + PVR-500

1. Reboot. Main screen. Hit Watch Live TV. Tuner 1 looks good.
saa7115: decoder set picture bright=127 contrast=63 saturation=63 hue=0
...

2. Change from Tuner 1 to Tuner 2. Looks good.
...
cx25840: decoder set size 720x480 (from 720x487) -> scale 0x65529, filter 0
...

3. Change from Tuner 2 to Tuner 3. Looks good.
...
cx25840: decoder set size 720x480 (from 720x487) -> scale 0x65529, filter 0
...

4. Change from Tuner 3 to Tuner 1. Looks good.
saa7115: decoder set picture bright=127 contrast=63 saturation=63 hue=0
...

5. Change from Tuner 1 to Tuner 3 again. ***PROBLEM SHOWS UP***.
...
cx25840: decoder set size 720x480 (from 720x580) -> scale 0x65430, filter 0
...

"x580"???

------

Something is setting the VSC value incorrectly before the line you
commented out.  I'm clarifying that just to suggest that commenting out
the line might return as a different bug later and discovering the cause
of the mis-set VSC might be worth it...  :)

But again, very very pleased with the driver set.  You do rock.

-brendan


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel

Reply via email to