Attendees: Michael Bouschen, Tobias Bouschen, Craig Russell Next meeting: Thursday February 9 1200 PST 2100 CET
Agenda: 1. JIRA JDO-819 "Code quality analysis" https://issues.apache.org/jira/browse/JDO-819 JIRA JDO-823 "Fix sonarcloud issues of type Code Smells" https://issues.apache.org/jira/browse/JDO-823 Sonarcloud link: https://sonarcloud.io/summary/overall?id=db-jdo <https://sonarcloud.io/summary/overall?id=db-jdo> Some candidate code smells to be discussed: https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1948&severities=CRITICAL&id=db-jdo 1. JDOException class contains an Object. Solution: make the field transient 2. SingleFieldIdentity class contains Object keyAsObject. AI: Tobias look at solutions. There is a case where a user-defined type could be the key. Solution: Leave it as is and mark it as "won't fix". 3. InstanceLifeCycleEvent contains Object target. Solution: make the field transient. https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS2692&severities=CRITICAL&id=db-jdo Looks like a false positive. https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1192&severities=CRITICAL&id=db-jdo file JDOConstants has two properties PROPERTY_ENHANCER_VENDOR_NAME and PROPERTY_ENHANCER_VERSION_NUMBER "Fixing" this would be a breaking change, so mark as "will not fix". https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1214&severities=CRITICAL&id=db-jdo Won't fix. https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS127&severities=MAJOR&id=db-jdo public class Enhancer: Refactor the code in order to not assign to this loop counter from within the loop body Won't fix. https://sonarcloud.io/project/issues? resolved=false&rules=java%3AS112&severities=MAJOR&id=db-jdo AI Michael: Look at solutions https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1185&severities=MINOR&id=db-jdo Removing this method would also remove the javadoc. Resolution: won't fix. https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1481&severities=MINOR&id=db-jdo Leave as is. Resolution: won't fix. AI Michael: merge fixes to main. 2. JIRA JDO-709 "Standardize field/property converters" https://issues.apache.org/jira/browse/JDO-709 3. JIRA JDO-822: "Verify compatibility with JDK 20" https://issues.apache.org/jira/browse/JDO-822 4. JIRA JDO-812 "Move to JDK 11 as the lowest supported version" https://issues.apache.org/jira/browse/JDO-812 5. Other issues Action Items from weeks past: [Nov 23 2022] AI Tilmann follow up with Andy/DataNucleus for his advice on JDO-709. [Oct 20 2022] AI Craig update the JIRA JDO-709 to request a test case using annotations and results of the test. [Dec 09 2021] AI Craig: Try to contact all current/former participants in JDO development and see if and how they want to be recognized on the JDO and DB web sites.https://db.apache.org/whoweare.html [Oct 07 2021] AI Craig send a private message to all JSR-243 Expert Group members asking if they wish to continue. [Mar 25 2021] AI Craig: investigate "merging" papajdo and apache.clr accounts [Oct 17 2014] AI Matthew any updates for "Modify specification to address NoSQL datastores" https://issues.apache.org/jira/browse/JDO-651 Craig L Russell c...@apache.org
