[GitHub] [kafka] divijvaidya commented on a diff in pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

[via GitHub]

divijvaidya commented on code in PR #13828:
URL: https://github.com/apache/kafka/pull/13828#discussion_r1223142144


##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -197,7 +199,8 @@ class BrokerServer(
       logManager = LogManager(config, initialOfflineDirs, metadataCache, 
kafkaScheduler, time,
         brokerTopicStats, logDirFailureChannel, keepPartitionMetadataFile = 
true)
 
-      remoteLogManager = createRemoteLogManager(config)
+      val remoteLogManagerConfig = new RemoteLogManagerConfig(config)

Review Comment:
   Correct me if I am wrong here but we already have RemoteLogManagerConfig. It 
is used here:
   
   
https://github.com/apache/kafka/blob/513e1c641d63c5e15144f9fcdafa1b56c5e5ba09/core/src/main/scala/kafka/log/LogManager.scala#L1405
   
   Hence, we can simply do 
`createRemoteLogManager(config.remoteLogManagerConfig)` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org