chia7712 commented on code in PR #15822:
URL: https://github.com/apache/kafka/pull/15822#discussion_r1581994613
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -77,7 +78,7 @@ public class CommonClientConfigs {
public static final String CLIENT_RACK_CONFIG = "client.rack";
public static final String CLIENT_RACK_DOC = "A rack identifier for this
client. This can be any string value which indicates where this client is
physically located. It corresponds with the broker config 'broker.rack'";
- public static final String DEFAULT_CLIENT_RACK = "";
+ public static final String CLIENT_RACK_DEFAULT = "";
Review Comment:
> do we need a KIP to move the default values to CommonClientConfigs as well?
yep ! see the following KIP rules:
```
What is considered a "major change" that needs a KIP?
...
Any change that impacts the public interfaces of the project
All of the following are public interfaces that people build around:
...
Configuration, especially client configuration
...
New or Changed Public Interfaces: impact to any of the "compatibility
commitments" described above. We want to call these out in particular so
everyone thinks about them.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
