I've just had a more detailed look at the patch file, and it contains lots of irrelevant/unnecessary changes.
I'm afraid the patches cannot be applied as they stand - there's far too much work involved. I suggest you attach the new files as files, rather than patches (zip them up as there are quite a few). Any _essential_ changes to existing files should be attached as one or more patch files. These should be in unified diff against the branch/rel-2-2 code. S On 26/02/07, sebb <[EMAIL PROTECTED]> wrote:
I have just had a very quick look at the patch. It's not immediately clear if it can be added to the JMeter code-base, as there seem to be changes to quite a few utility classes. The changes may be upwards-compatible, but I cannot tell at present. There seem to be several irrelevant changes (e.g. to formatting) which make the review quite time-consuming. I'll try and have a more detailed look later. S On 26/02/07, Guillaume Lasnier <[EMAIL PROTECTED]> wrote: > Hi, > Same question again. I noticed that a new release of JMeter is now out and > does not include this contribution. Seb do you have any idea if you plan to > integrate it and when? > Regards > > Guillaume Lasnier * Software Engineer * SunGard * Decalog * 147 Bureaux de > la Colline, Bâtiment E * 92213 Saint-Cloud CEDEX * France * Phone: +33 1 55 > 39 18 74 * Fax: +33 1 55 39 18 01 * www.sungard.com <www.sungard.com> > > > > > _____________________________________________ > > From: Guillaume Lasnier <[EMAIL PROTECTED]>@SUNGARD > > Sent: Monday, August 28, 2006 10:00 AM > > To: JMeter Developers List (E-mail) > > Subject: Session Bean Sampler > > > > > > Hi all, > > As anyone tried the Session Bean Sampler submitted here > > http://issues.apache.org/bugzilla/show_bug.cgi?id=40181 > > <http://issues.apache.org/bugzilla/show_bug.cgi?id=40181> ? > > I would appreciate feed backs. > > > > -- > > Guillaume Lasnier > > Technical R&D > > Phone : +33 1 55 39 18 74 > > > > > > > > > > > > Confidentiality Notice: The information contained in this e-mail message > > is > > intended only for the personal and confidential use of the recipient(s) > > named above. If the reader of this message is not the intended recipient > > or > > an agent responsible for delivering it to the intended recipient, you are > > hereby notified that you have received this document in error and that any > > review, dissemination, distribution, or copying of this message is > > strictly > > prohibited. If you have received this communication in error, please > > notify > > us immediately by e-mail, and delete the original message. > > > > Message confidentiel : Les informations contenues dans ce message sont > > destinées à un usage personnel et confidentiel du destinataire indiqué > > ci-dessus. Si le lecteur de ce message n'est pas le destinataire prévu, ou > > n'est pas une personne en charge de le délivrer au destinataire voulu, > > vous > > êtes par la présente informé que vous avez reçu ce document par erreur, et > > que tout examen, transmission, distribution ou copie de ce message est > > totalement interdit. Si vous avez reçu cette communication par erreur, > > nous > > vous remercions de bien vouloir nous avertir immédiatement par e-mail et > > de > > détruire le message d'origine. > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > Confidentiality Notice: The information contained in this e-mail message is > intended only for the personal and confidential use of the recipient(s) > named above. If the reader of this message is not the intended recipient or > an agent responsible for delivering it to the intended recipient, you are > hereby notified that you have received this document in error and that any > review, dissemination, distribution, or copying of this message is strictly > prohibited. If you have received this communication in error, please notify > us immediately by e-mail, and delete the original message. > > Message confidentiel : Les informations contenues dans ce message sont > destinées à un usage personnel et confidentiel du destinataire indiqué > ci-dessus. Si le lecteur de ce message n'est pas le destinataire prévu, ou > n'est pas une personne en charge de le délivrer au destinataire voulu, vous > êtes par la présente informé que vous avez reçu ce document par erreur, et > que tout examen, transmission, distribution ou copie de ce message est > totalement interdit. Si vous avez reçu cette communication par erreur, nous > vous remercions de bien vouloir nous avertir immédiatement par e-mail et de > détruire le message d'origine. >
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
