-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2013-09-10 12:39, Frank Mueller wrote: > Hi all, > > as on-call reviewer today I've again seen the difference between > > https://code.launchpad.net/juju-core/+activereviews > > and > > https://codereview.appspot.com/mine > > There are many unclosed reviews on Rietveld. This may not be our > main list, but it would help if those CL which are merged or > discarded would be closed there too. > > thx mue >
Is that actually intended to be part of the workflow? It ends up with several more clicks and delays for round trips (you have to wait for your patch to land, then click back through and close the Rietveld ticket, etc.) My understanding was that the "queue of things to review" was strictly +activereviews (which has the really nice property that Launchpad notices when it is merged and sets the MP to the right status for us). John =:-> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (Cygwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlIu/AYACgkQJdeBCYSNAAPcGQCgkCzvknKoMR9AkOb2HjQzsv4t 4/AAnRIFWgjnTyPwE8IUTvAGVjtCb2Dd =w1Pe -----END PGP SIGNATURE----- -- Juju-dev mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
