hmm.. there's three distinct threads here. default-hook -> charms that do so symlink 0-100% -> to one hook.. in practice everything, sometimes minus install (as the hook infrastructure needs pkgs).. and most typically implemented via dispatch table.
something-changed -> completely orthogonal to either the default-hook merge request, and in practice full of exceptions, but useful as an optimization of event collapsing around charms capable of event coalescence periodic async framework invoked -> metrics and health checks. afaics best practices around these would be not invoking default-hook which is lifecycle event handler, while these are periodic poll, yes its possible but it conflates different roles. cheers, Kapil also +1 to default-hook using JUJU_HOOK_NAME. On Tue, Aug 19, 2014 at 6:10 PM, Gustavo Niemeyer <gust...@niemeyer.net> wrote: > On Tue, Aug 19, 2014 at 6:58 PM, Matthew Williams > <matthew.willi...@canonical.com> wrote: > > Something to be mindful of is that we will shortly be implementing a new > > hook for metering (likely called collect-metrics). This hook differs > > slightly to the others in that it will be called periodically (e.g. once > > every hour) with the intention of sending metrics for that unit to the > state > > server. > > > > I'm not sure it changes any of the details in this feature or the pr - > but I > > thought you should be aware of it > > Yeah, that's a good point. I'm wonder how reliable the use of > default-hook will be, as it's supposed to run whenever any given hook > doesn't exist, so charms using that feature should expect _any_ hook > to be called there, even those they don't know about, or that don't > even exist yet. The charms that symlink into a single hook seem to be > symlinking a few things, not everything. It may well turn out that > default-hook will lead to brittle charms. > > > gustavo @ http://niemeyer.net > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev >
-- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
