On Fri, 12 Apr 2002 15:58:56 +1000, 
Brendan J Simon <[EMAIL PROTECTED]> wrote:
>In kbuild-2.5-release-1.12, some of the script files are checked for the 
>correct permissions (see below for scripts/Makefile-2.5 fragment). 
> Instead of trying to change the permissions of the source tree (which 
>might be owned by another user, eg. aegis), would it be possible to 
>_copy_ these files to the KBUILD_OBJTREE directory and then change the 
>permissions ?
>
>Cheers,
>Brendan Simon.
>
># The patch command does not set execute permission on scripts, which is 
>a big
># nuisance.  A tar ball will have the correct permissions in the source 
>tree, a
># patched tree will not.  So whenever a user does make *config, check and
># correct the problem permissions.  Yes, this writes to the source tree 
>but I
># don't see any alternative.  The write is only done once and only if 
>patch has
># corrupted the source tree permissions.  KAO
>
>$(config_targets): correct_permissions
>.PHONY: correct_permissions
>correct_permissions:
>        @[ -x $(scripts_srctree)lilo_new_kernel ] || chmod a+x 
>$(scripts_srctree)lilo_new_kernel
>        @[ -x $(scripts_srctree)docgen ] || chmod a+x 
>$(scripts_srctree)docgen
>        @[ -x $(scripts_srctree)kernel-doc ] || chmod a+x 
>$(scripts_srctree)kernel-doc
>        @[ -x $(scripts_srctree)gen-all-syms ] || chmod a+x 
>$(scripts_srctree)gen-all-syms

Not everybody runs with a separate object directory.  An alternative is
not to execute those scripts directly, instead execute them via
$(KBUILD_SHELL) or $(PERL) as required (kernel-doc is Perl, the others
are shell).  Then they do not need execute permissions.

I will add this to my todo list for the next core release.  Right now I
am deep in 2.5.8-pre3 - 253 Makefile.in files and counting ...


_______________________________________________
kbuild-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/kbuild-devel

Reply via email to