https://bugs.kde.org/show_bug.cgi?id=380526

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/7bd909fa3a4f7
                   |                            |0bf4c03c43b025f7ed65c2e5b5c
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.10.1

--- Comment #15 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 7bd909fa3a4f70bf4c03c43b025f7ed65c2e5b5c by David Edmundson.
Committed on 05/06/2017 at 12:37.
Pushed by davidedmundson into branch 'Plasma/5.10'.

Only enable MPRIS global shortcuts on demand

Summary:
The lockscreen uses the MPRIS dataengine. This leads to two applications
registring the service using the same component name which leads to the
shortcuts not working when the lock screen closes.

We want to have the applet register the shortcuts, but not every
dataengine user.

Ideally this shouldn't be in the dataengine either because DataEngines
are read only. This moves the logic to the service which is writable and
registers the shortcuts for the multiplexer there when requested from
the applet.
FIXED-IN: 5.10.1

Test Plan:
Opened media player.
Used play/pause shortcut. (the only one my keyboard has)

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6100

M  +4    -0    applets/mediacontroller/contents/ui/main.qml
M  +58   -0    dataengines/mpris2/multiplexedservice.cpp
M  +5    -0    dataengines/mpris2/multiplexedservice.h
M  +0    -49   dataengines/mpris2/multiplexer.cpp

https://commits.kde.org/plasma-workspace/7bd909fa3a4f70bf4c03c43b025f7ed65c2e5b5c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to