https://bugs.kde.org/show_bug.cgi?id=389065
Bug ID: 389065
Summary: valgrind meets gcc flag -Wlogical-op
Product: valgrind
Version: 3.13 SVN
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: NOR
Component: general
Assignee: jsew...@acm.org
Reporter: dcb...@hotmail.com
Target Milestone: ---
1.
priv/guest_arm_toIR.c: In function ‘decode_V6MEDIA_instruction’:
priv/guest_arm_toIR.c:9149:31: warning: logical ‘or’ of collectively exhaustive
tests is always true [-Wlogical-op]
(INSNA(6,6) == 0 || INSNA(6,6) == 1) ) {
^~
I am guessing that INSNA(6,6) is only one bit.
2.
m_syswrap/syswrap-xen.c: In function ‘vgSysWrap_xen_domctl_before’:
m_syswrap/syswrap-xen.c:1281:84: warning: logical ‘or’ of equal expressions
[-Wlogical-op]
if (domctl->u.monitor_op_0000000b.op ==
VKI_XEN_DOMCTL_MONITOR_OP_ENABLE ||
domctl->u.monitor_op_0000000b.op ==
VKI_XEN_DOMCTL_MONITOR_OP_ENABLE) {
Maybe the second one should be DISABLE ?
I suggest also add gcc flag -Wlogical-op to future builds
to prevent this kind of bug happening again.
--
You are receiving this mail because:
You are watching all bug changes.
