https://bugs.kde.org/show_bug.cgi?id=361551

Martin Gräßlin <mgraess...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/kwin
                   |                            |/0df4406c2cf8df56f90a7a006e
                   |                            |b911775a120886
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.6.3
             Status|CONFIRMED                   |RESOLVED

--- Comment #9 from Martin Gräßlin <mgraess...@kde.org> ---
Git commit 0df4406c2cf8df56f90a7a006eb911775a120886 by Martin Gräßlin.
Committed on 14/04/2016 at 05:35.
Pushed by graesslin into branch 'Plasma/5.6'.

Fix crash on repainting an invalid sizes decoration

Summary:
If a window has an invalid size the decoration also has an invalid
size. This results in the texture used by the
SceneOpenGLDecorationRenderer to be invalid and being reset to null.
Of course we shouldn't try to use this texture to render to.

The change comes with a test case to simulate the situation. We cannot
simulate it with Wayland clients as the geometry can never be empty.
Thus we create an X11 client, resize it to an empty size and unmap it.

This is the first integration test case which creates an X11 Client!
It's also a test case which needs the OpenGL compositor. This will most
likely not work on build.kde.org yet - we need to see what to do about
it. Will need adjustments to get it at least skip on build.kde.org.
FIXED-IN: 5.6.3

Reviewers: #plasma

Subscribers: plasma-devel

Projects: #plasma

Differential Revision: https://phabricator.kde.org/D1383

M  +9    -0    autotests/wayland/CMakeLists.txt
A  +221  -0    autotests/wayland/dont_crash_empty_deco.cpp     [License: GPL
(v2)]
M  +1    -1    client.h
M  +5    -0    scene_opengl.cpp

http://commits.kde.org/kwin/0df4406c2cf8df56f90a7a006eb911775a120886

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to