https://bugs.kde.org/show_bug.cgi?id=410802
--- Comment #4 from Nikita Sirgienko <warqu...@gmail.com> --- (In reply to Luca Beltrame from comment #2) > (In reply to Nikita Sirgienko from comment #1) > > "discount-2.2.6-patched.tar" placed in cantor/thirdparty directory. It is > > It looks like it fails if LANG isn't properly set. If setting LANG to > "en_US.UTF-8" prior to building, it builds. I've edited the title to reflect > this. > > That said, it is not acceptable for distros to have bundled third party deps > (unless you can disable the bundled copy and use the system one), nor that > the feature summary doesn't tell you that it's going to use a bundled > library. > > The README should also mention this. So you suggest to add information in README, that Cantor uses bundled third party library, right? Could you also give an example, how information like that is mentioned in KDE programs? > That won't fly with distributions for a lot of good reasons: what if the > bundled library does not build anymore for newer compilers? What if there is > a security vulnerability in the bundled library that is not patched? What if > there are bugs in the bundled library that are fixed in newer versions? Of course, current situation with Discount always planned as temporary solution. > As this change is in master only, there is enough time for 19.12 to: > > a. Submit discount changes upstream > b. Allow the build system to *not* use the bundled discount fork (because > that's what it is) > c. Write at the end of the cmake call whether a bundled library is being > used or not. Not sure about 19.12, I mean, I will send pull request in few days, but I don't know, how fast upstream will respond and which Discount version will available for 19.12 But, just in case, for variant, when needed changes won't be available in system library version, that you could recommend? -- You are receiving this mail because: You are watching all bug changes.
