https://bugs.kde.org/show_bug.cgi?id=253657

Julian Seward <jsew...@acm.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59716|0                           |1
        is obsolete|                            |
 Attachment #122256|0                           |1
        is obsolete|                            |

--- Comment #29 from Julian Seward <jsew...@acm.org> ---
Created attachment 125367
  --> https://bugs.kde.org/attachment.cgi?id=125367&action=edit
Rollup patch, which is simply the 15 patches merged

Here's a rollup patch, which is just the previous 15 patches merged and
with a bit of reformatting.  It applies to the trunk as at 24 Jan 2020.

I haven't landed it because the change in coregrind/m_stacktrace.c potentially
gives a large performance problem.  If the call to VG_(use_CFI_info) fails,
then
we now try with VG_(use_MSVC_x64_info).  That is guaranteed to fail in "normal"
(non-Wine) use.  But before it fails it could potentially visit the entire
debugInfo
list, which can contains hundreds of DebugInfos for large complex applications.

The obvious fix is to keep a boolean indicating whether any Windows unwind
info has been loaded, and if false, just skip this call.  That would remove the
perf hit for non-Wine use.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to