https://bugs.kde.org/show_bug.cgi?id=422042

Zauberfisch <accounts.bugs.kde....@zauberfisch.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |albertv...@gmail.com

--- Comment #2 from Zauberfisch <accounts.bugs.kde....@zauberfisch.at> ---
@albertvaka I found the following commit from you in 2017:

https://invent.kde.org/frameworks/knotifications/-/commit/579b75aac8e2323e3b16fc7f114efd10d4a77e07

The commit message says "Mark non-persistent notifications as transient", but
to my understanding the code is the opposite:

    if (!(notification->flags() & KNotification::Persistent)) {
        hintsMap[QStringLiteral("transient")] = true;
    }

can you confirm that this was a typo, and that it should be &
!KNotification::Persistent instead?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to