https://bugs.kde.org/show_bug.cgi?id=433439

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m...@klomp.org

--- Comment #2 from Mark Wielaard <m...@klomp.org> ---
I think the new NSegment field in include/pub_tool_aspacemgr.h should be
guarded by:

#if defined(VGO_freebsd)
      Bool    isFF;     // True --> is a fixed file mapping
#endif

As it is only used by freebsd.

The types in include/pub_tool_basics.h seem properly guarded.

The &qq_option[2] in include/pub_tool_options.h looks correct.

Adding const to the VG_(sysctl) void *newp would break some code and seems
unnecessary.

The comment and inclusion of vki/vki-scnums-freebsd.h in
include/pub_tool_vkiscnums.h seems unneeded.

The new vki files are only used by freebsd and I assume they describe things
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to