https://bugs.kde.org/show_bug.cgi?id=433507
Mark Wielaard <m...@klomp.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m...@klomp.org
--- Comment #3 from Mark Wielaard <m...@klomp.org> ---
Because some of the earlier patches changed some things don't apply anymore,
like .gitignore but that seems harmless.
The configure.ac filter AC_CONFIG_FILES don't apply anymore, but it is clear
where they should go. The new memcheck/tests/freebsd/Makefile,
memcheck/tests/amd64-freebsd/Makefile and memcheck/tests/x86-freebsd/Makefile
are missing in configure.ac as AC_CONFIG_FILES.
Is the filename memcheck/tests/dw4.stderr.exp-freebad a joke or a typo? I like
the joke, but if you decide to "fix" it don't forget to also fix it in
memcheck/tests/Makefile.am EXTRA_DIST.
memcheck/tests/addressable.c I think you can just unconditionally include
signal.h. But that would mean changing the .exp files again. So probably don't
bother.
memcheck/tests/err_disable4.c pthread_attr_setstacksize isn't freebsd specific.
Why was it added?
memcheck/tests/Makefile.am
memcheck/tests/x86/more_x86_fp.c
memcheck/tests/x86/pushfpopf_s.S
memcheck/tests/str_tester.c
memcheck/tests/vbit-test/util.c
memcheck/tests/vbit-test/vbits.c
are made executable, they shouldn't
memcheck/tests/x86/filter_pushfpopf should be deleted (now that there is an .in
file)
The posix_fadvise and posix_fallocate tests might be made non-freebsd specific
(they are posix after all). But maybe afterwards.
The naming of filter_varinfo3 is somewhat unfortunate now that it is used by
multiple other vgtests too.
I didn't review all of the new freebsd tests, but assume they are fine (they
don't execute locally on Fedora)
--
You are receiving this mail because:
You are watching all bug changes.
