https://bugs.kde.org/show_bug.cgi?id=450727

Ahmad Samir <a.samir...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.96
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kio/commit/a4be43231
                   |                            |840a145c808f6ce81217f02f039
                   |                            |35e8
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit a4be43231840a145c808f6ce81217f02f03935e8 by Ahmad Samir.
Committed on 13/06/2022 at 19:19.
Pushed by ahmadsamir into branch 'master'.

KPropertiesDialog: fix saving changes when editing a .desktop file symlink

Consider the use case of:
/usr/share/applications/foo.desktop is symlink to /opt/someapp/foo.desktop

relativeAppsLocation() was using QFile::canonicalFilePath(), which meant
that foo.desktop would resolve to a file outside /usr/share/applications,
since the code, rightly, expects files in QStandardPaths::ApplicationsLocation
locations, m_sRelativePath would end up being empty, which makes the check in
KFilePropsPlugin::slotCopyFinished() fail, and the .desktop file wouldn't
get copied to ~/.local/share/applications/, and the saving would fail.
FIXED-IN: 5.96

M  +5    -3    src/widgets/kpropertiesdialog.cpp

https://invent.kde.org/frameworks/kio/commit/a4be43231840a145c808f6ce81217f02f03935e8

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to