https://bugs.kde.org/show_bug.cgi?id=462879

sh_zam <sh...@sdf.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/krita/commit/dc824a4c0
                   |                            |c73e726950354d8f8a55ac25ac2
                   |                            |3424
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from sh_zam <sh...@sdf.org> ---
Git commit dc824a4c0c73e726950354d8f8a55ac25ac23424 by Sharaf Zaman.
Committed on 14/12/2022 at 04:57.
Pushed by rempt into branch 'master'.

LayerBox: Fix the bug with layer not getting selected

When a new layer was created we wouldn't select it due to
selectionModel()->hasSelection() clause -- which assumed that if there
was a already a layer selected then the new layer would clear selection
when it shouldn't.

In addition to this, there was a bug caused by currentChanged calling
setData(). This resulted in dataChanged() being called by a signal which
in turn called setCurrentIndex again but this time since no selection
flags were persisted this would update the selection when it shouldn't.

Now, we add a signal blocker since we're just adding a UserRole and the
only calls that seem to rely on this signal are updateUI -- which gets
called anyways. So, it should be safe, I assume.

M  +2    -7    plugins/dockers/layerdocker/NodeView.cpp

https://invent.kde.org/graphics/krita/commit/dc824a4c0c73e726950354d8f8a55ac25ac23424

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to