https://bugs.kde.org/show_bug.cgi?id=372248

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/plas
                   |                            |ma-workspace/7248a71a959f20
                   |                            |99a4c27533c5316345c1a11fa1

--- Comment #5 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 7248a71a959f2099a4c27533c5316345c1a11fa1 by David Edmundson.
Committed on 22/11/2016 at 10:29.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Don't set PanelView visibilty when opening/closing config

Summary:
    Instead of making PanelViewConfig manipulate the visibiltyMode of
    PanelView, make PanelView force the view to be visible whilst the
config
    is open.

    This is cleaner as it doesn't alter the original config, and
resolves a
    bug that opening configure with an autohide panel would shift
contents
    about.

Test Plan:
With panel as autohide opened config
Moused away from panel, panel stayed visible

With panel as autohide, plugged in a USB pen - panel appeared - and
closed when I hid the dialog

Changed mode in panel config, panel didn't immediately change - but did
on close.
Tested with all modes.

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3408

M  +2    -15   shell/panelconfigview.cpp
M  +0    -1    shell/panelconfigview.h
M  +28   -9    shell/panelview.cpp

http://commits.kde.org/plasma-workspace/7248a71a959f2099a4c27533c5316345c1a11fa1

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to