https://bugs.kde.org/show_bug.cgi?id=352395

--- Comment #22 from Austin English <austinengl...@gmail.com> ---
(In reply to Ivo Raisr from comment #20)
> Patch #6 seems to be working well. I tested it on Solaris, inside SVN tree,
> outside and after 'make dist'.
> 
> In addition to the last comment by Austin, please change also:
> 
> auxprogs/make_or_upd_vgversion_h:
> -   when using command lines options:  -v --version 
> +   when using command line options:  -v --version 
> 
> and make sure that auxprogs/make_or_upd_vgversion_h is marked as executable
> in SVN repository.

Yeah, it fails for me out of the box, with:
echo "# This is a generated file, composed of the following suppression rules:"
> default.supp
auxprogs/make_or_upd_vgversion_h
make: execvp: auxprogs/make_or_upd_vgversion_h: Permission denied
Makefile:1374: recipe for target 'vgversion.h' failed
make: *** [vgversion.h] Error 127
make: *** Waiting for unfinished jobs....
echo "# " exp-sgcheck.supp xfree-3.supp xfree-4.supp glibc-2.X-drd.supp
glibc-2.34567-NPTL-helgrind.supp glibc-2.X.supp  >> default.supp
cat exp-sgcheck.supp xfree-3.supp xfree-4.supp glibc-2.X-drd.supp
glibc-2.34567-NPTL-helgrind.supp glibc-2.X.supp >> default.supp

chmod +x auxprogs/make_or_upd_vgversion_h gets past that problem.

Next, it fails for VEX, with git svn:
valgrind-3.12.0.SVN-16107-vex-

+        git svn info $1 | grep '^Revision' | cut -d ' ' -f2 | tr -d '\n'

won't work the way you expect. It needs to be in the VEX directory for this to
work:
austin@austin2:~/src/valgrind-git$ git svn info | grep Revision
Revision: 16107

austin@austin2:~/src/valgrind-git$ git svn info VEX | grep Revision
svn: 'VEX' is not under version control

austin@austin2:~/src/valgrind-git$ cd VEX && git svn info | grep Revision
Revision: 3276

FYI, I can also text on OSX (once these issues are sorted out ;) ).

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to