-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111585/
-----------------------------------------------------------
(Updated July 20, 2013, 2:06 p.m.)
Review request for kdelibs and David Faure.
Changes
-------
Uploaded the correct patch.
Description
-------
The attached patch fixes a bug where the contents of the clipboard are
prematurely updated during a cut and paste operation. In the process I also
discovered that undoing the operation does not update the clipboard either.
Hence that too is fixed by this patch.
Please note that this patch does not address all the cases where the content of
the clipboard is not updated after a KIO operation. More specifically the
clipboard content will be out of sync if the user performs the following
operations:
- copy/cut a file or a directory and rename it
- copy/cut a file or a directory and move it
- copy/cut a file or a directory and delete it.
In fact there is a ticket for the copy/cut and rename file/directory scenario
(bug# 134960). However, addressing these issues require a careful consideration
of how to do it since delete/rename/move operations can be done outside of
KDE's control. Do we simply fix the KIO jobs to handle this or do we address it
the KDirWatch level so we catch all the scenarios? Probably the latter. Anyhow,
that can wait until for the 134960 fix.
This addresses bug 318757.
http://bugs.kde.org/show_bug.cgi?id=318757
Diffs (updated)
-----
kio/CMakeLists.txt f7a3767
kio/kio/clipboardupdater.cpp PRE-CREATION
kio/kio/clipboardupdater_p.h PRE-CREATION
kio/kio/fileundomanager.cpp 9f76fef
kio/kio/paste.cpp ca451fb
kio/tests/fileundomanagertest.h ebd02fa
kio/tests/fileundomanagertest.cpp 7c1352c
Diff: http://git.reviewboard.kde.org/r/111585/diff/
Testing
-------
Unit and manual tests.
Thanks,
Dawit Alemayehu
