----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113364/#review42328 -----------------------------------------------------------
I have no objection to this patch. However, I want to make sure you have tested the other modes before I give it a thumbs up. Did you try the manual proxy setup with your patch? Also adding some exceptions to make sure it honors those as well? If not can you please do that I do not have the bandwidth to test that at the moment. - Dawit Alemayehu On Oct. 21, 2013, 1:41 p.m., Andrea Iacovitti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113364/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2013, 1:41 p.m.) > > > Review request for kdelibs and Dawit Alemayehu. > > > Repository: kdelibs > > > Description > ------- > > Fix the code to determine if a proxy or direct connection should be made in > the case where multiple proxies are availables and between them the keyword > "DIRECT" is present. We should first verify if the candidate proxy string is > equal to "DIRECT" (and then try to make a direct connection) and after try to > construct KUrl object. > Otherwise we would never be able to direct connect because KUrl("DIRECT") is > not a valid (proxy) url. > > > Diffs > ----- > > kioslave/http/http.cpp 81182eb > > Diff: http://git.reviewboard.kde.org/r/113364/diff/ > > > Testing > ------- > > Tested against various PAC scripts returning, for example, proxies list like: > ("http://127.0.0.1:3333";, "DIRECT") or ("DIRECT", "http://127.0.0.1:3333";) > > Note: in case PAC script returns "DIRECT" only, this code path is not > executed as m_request.proxyUrls will be empty. > > > Thanks, > > Andrea Iacovitti > >
