> On Nov. 10, 2013, 3:51 p.m., David Faure wrote: > > kio/bookmarks/kbookmarkimporter_ns.cc, line 65 > > <http://git.reviewboard.kde.org/r/113785/diff/1/?file=212403#file212403line65> > > > > (could be more optimized with startsWith("<HR>", Qt::CaseInsensitive) > > -- but ok, the rest of the code uses toUpper, so this is ok for this commit)
No because "t" is a QByteArray and its startsWith method does not have a Qt::CaseSensitvity parameter like QString. - Dawit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113785/#review43352 ----------------------------------------------------------- On Nov. 10, 2013, 2:51 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113785/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2013, 2:51 p.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 292495 > http://bugs.kde.org/show_bug.cgi?id=292495 > > > Repository: kdelibs > > > Description > ------- > > Currently the Mozilla bookmark importing code simply ignores any HTML tags > preceded by the <HR> element resulting in lines like > > <HR> <DT><H3 ADD_DATE="1364760832" LAST_MODIFIED="1364760921">magie</H3> > > simply being treated as a separator instead of a separator followed by a > bookmark entry. The attached patch addresses this problem. > > > Diffs > ----- > > kio/bookmarks/kbookmarkimporter_ns.cc d3f0eaa > > Diff: http://git.reviewboard.kde.org/r/113785/diff/ > > > Testing > ------- > > > Thanks, > > Dawit Alemayehu > >
