> On March 6, 2014, 9:10 p.m., Andrea Iacovitti wrote: > > I tested your patch, no trailing slash is added whether the request refers > > to a collection or resource (as it was before commit 58294ac). > > Dawit Alemayehu wrote: > Right, but now the webdav server should redirect to the right address > (with trailing slash) and that redirect should succeed. I guess we can always > add a trailing slash if there are servers that do not redirect or we want to > avoid the redirect.
Well, not mine, i get a 204 and the forlder successfully deleted. - Andrea ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116122/#review52294 ----------------------------------------------------------- On March 5, 2014, 2:01 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116122/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 2:01 p.m.) > > > Review request for kdelibs, Andrea Iacovitti and David Faure. > > > Bugs: 331295 > http://bugs.kde.org/show_bug.cgi?id=331295 > > > Repository: kdelibs > > > Description > ------- > > This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, > which attempted to workaround webdav servers that do not accept delete > requests on directories unless there is a trailing slash. It ensures that the > "fix" is only applicable to webdav and the addition of the trailing slash is > communicated to the client application. > > > Diffs > ----- > > kio/kio/deletejob.cpp b0268ef > kioslave/http/http.cpp b4d64d4 > > Diff: https://git.reviewboard.kde.org/r/116122/diff/ > > > Testing > ------- > > For HTTP delete: > http://greenbytes.de/tech/tc/httpredirects/t301methods.html > > For WebDAV delete: > http://boonfaya.com/sites/webdavapps.com/#targets > > > Thanks, > > Dawit Alemayehu > >