pdabrowski added inline comments.

INLINE COMMENTS

> broulik wrote in dolphinmainwindow.cpp:2289
> > It is a rare occasion that user changes preferred search tools,
> 
> So, the URL does not have any impact on the search tool chosen? I thought 
> that was the main reason for using the URL and updating it all the time.

> So, the URL does not have any impact on the search tool chosen? I thought 
> that was the main reason for using the URL and updating it all the time.

This depends on KMoreToolsMenuFactory. But it doesn't seem to choose different 
tools for different URLs.

The main reason for the updates was so that all the Open Preferred Search Tool 
actions reflect the user choice of preferred tool (can be modified with More 
Search Tools -> More -> Configure)
See: https://phabricator.kde.org/D22594#499652

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: broulik, pkloc, kfm-devel, kde-doc-english, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, gennad, fbampaloukas, alexde, Codezela, feverfew, 
meven, spoorun, navarromorales, firef, ngraham, andrebarros, skadinna, 
emmanuelp, rdieter, mikesomov

Reply via email to