ervin added inline comments.
INLINE COMMENTS
> kconfigtest.cpp:1953
> +
> +void KConfigTest::testKdeglobalsVSDefault()
> +{
Seeing how this test confuses everyone (including me and I knew the problem
before hand...), I think it'd benefit greatly from getting comments at the most
important points in its execution (similarly to other tests in that file).
> kconfigtest.h:76
>
> + void testKdeglobalsVSDefault();
> +
nitpick: should be "Vs"
> kconfigdata.cpp:105
> + if (e.bGlobal && !(options & EntryGlobal) && !k.bDefault)
> + {
> + e.bOverridesGlobal = true;
Should be at the end of the previous line
> kconfigdata.h:63
> + /**
> + * Entry will need to be written on a not global file even if it matches
> default value
> + */
nitpick: I think I'd write "non global" rather than "not global"
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D28128
To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
