ervin requested changes to this revision.
ervin added inline comments.
INLINE COMMENTS
> kconfigskeletontest.cpp:25
>
> +static inline QString kdeGlobalsPath() {
> + return
> QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) +
> "/kdeglobals";
{ should be on its own line
> kconfigskeletontest.cpp:29
> +
> +static inline QString kdeSystemGlobalsPath() {
> + return
> QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) +
> "/system.kdeglobals";
ditto
> kconfigskeletontest.cpp:190
> +{
> + // This test ensure we don't override default value when this one came
> from a file
> + // system.kdeglobals is a global file and can provide default
s/ensure/ensures/
> kconfigskeletontest.cpp:218
> + QCOMPARE(item->value(), 30);
> +}
More comments welcome in that test as well.
> kcoreconfigskeleton.cpp:13
> #include <QUrl>
> +#include <QDebug>
>
Looks like this include is unused
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D28221
To: bport, ervin, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
