ervin added a comment.
In D28742#646050 <https://phabricator.kde.org/D28742#646050>, @dfaure wrote: > In D28742#646009 <https://phabricator.kde.org/D28742#646009>, @kossebau wrote: > > > And perhaps could be defaulted to nullptr, for use-cases which do not have a window at hand and are fine with any default? > > > I've been wondering. But people tend to forget to do so, and in most cases, if we choose the dialog delegate, then there's a QWidget based window somewhere. > Plasma uses KNotificationJobUiDelegate so it's not a problem here. > My thinking is that I'd rather force people to think about it, and possibly pass a nullptr in case there's really no window around. +1, I don't think defaulting to nullptr is a good idea. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
