ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, blaze. Herald added a project: Frameworks. ahmadsamir requested review of this revision.
REVISION SUMMARY QRegularExpression::wildcardToRegularExpression() mainly handles file pattern globbing (e.g. "*.txt") which means it doesn't allow "/" in the file name (which is technically correct); but we have to subvert it because the keys in kwallet are in the form "foobar.com/<User name>" which does have a "/" in it. It's a hack, but it works here because in reality, there're no actual files/folders in kwallet, it's just data structures and "/" is an acceptable separator. TEST PLAN - make && ctest - The password dialog in Falkon still wors REPOSITORY R311 KWallet BRANCH l-wildcard (branched from master) REVISION DETAIL https://phabricator.kde.org/D28880 AFFECTED FILES src/api/KWallet/kwallet.cpp src/runtime/kwalletd/backend/kwalletbackend.cc To: ahmadsamir, #frameworks, dfaure, blaze Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
