bruns added inline comments.

INLINE COMMENTS

> thumbnail.cpp:726
>  
> +            const auto mountsList = KMountPoint::currentMountPoints();
> +            const auto mount =  mountsList.findByPath(filePath);

Calling currentMountPoints() for every created file is definitely a bad idea ...

https://github.com/KDE/kio/blob/master/src/core/kmountpoint.cpp#L272

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik, 
pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
rdieter, mikesomov

Reply via email to