meven accepted this revision. meven added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > filewatchtest.cpp:223 > + QEXPECT_FAIL("", "Removal of excluded folders not deteced", Continue); > + QVERIFY(spyIndexNew.wait(500)); > + for (const QList<QVariant>& event : qAsConst(spyIndexNew)) { Maybe less, to keep the test reasonably fast. REPOSITORY R293 Baloo BRANCH fwtest REVISION DETAIL https://phabricator.kde.org/D29190 To: bruns, #baloo, ngraham, meven Cc: meven, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams