ervin added inline comments. INLINE COMMENTS
> meven wrote in device.h:99 > Well I have to make this virtual it seems so this call is dynamically > dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), > QString(), displayName());` > I assumed this would work based on my review comments rather than on tests :/ Woops... my bad, indeed didn't notice it wasn't marked virtual anymore. It has to be indeed. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure, ngraham Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns