-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello,
thanks for your patch. I agree with you, that a recommends isn't a long time solution. Before I apply your patch I want to ask the kdenlive developers, if they maybe have got a better option for it in future releases (something like configuring it with --with-genisoimage). - -------- Original-Nachricht -------- Betreff: Bug#547501: kdenlive: Reccomends genisoimage, but needs the mkisofs symlink Weitersenden-Datum: Sun, 20 Sep 2009 12:15:01 +0000, Sun, 20 Sep 2009 12:15:06 +0000 Weitersenden-Von: Didier Raboud <[email protected]> Weitersenden-An: [email protected] Weitersenden-CC: Patrick Matthäi <[email protected]> Datum: Sun, 20 Sep 2009 13:44:44 +0200 Von: Didier Raboud <[email protected]> Antwort an: Didier Raboud <[email protected]>, [email protected] An: Debian Bug Tracking System <[email protected]> Package: kdenlive Version: 0.7.5-1 Severity: normal Tags: patch Hi, kdenlive "Recommends" genisoimage but needs the mkisofs symlink (from the dummy mkisofs package) to work. So I see two solutions: a) Recommend: mkisofs This is IMHO bad, because it is not a long-term solution. b) patch kdenlive to cope with Debian specifics (the genisoimage fork) You'll find the corresponding patch attached. Note that the "mkisofs" string is translated, but it is translated as "mkisofs" in all languages (or not translated), so I consider this not being an issue. Best regards, OdyX - -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (750, 'unstable'), (700, 'testing-proposed-updates'), (700, 'testing'), (90, 'experimental'), (50, 'testing-proposed-updates'), (50, 'experimental'), (50, 'unstable'), (50, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores) Locale: LANG=fr_CH.UTF-8, LC_CTYPE=fr_CH.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages kdenlive depends on: ii ffmpeg 4:0.5+svn20090706-2+b1 multimedia player, server and enco ii kdebase-runtime 4:4.3.1-1 runtime components from the offici ii kdelibs5 4:4.3.1-1 core libraries for all KDE 4 appli ii kdenlive-data 0.7.5-1 a non-linear video editor (data fi ii libc6 2.9-26 GNU C Library: Shared libraries ii libgcc1 1:4.4.1-4 GCC support library ii libmlt++2 0.4.4-2+b1 MLT multimedia framework C++ wrapp ii libmlt1 0.4.4-2+b1 multimedia framework (runtime) ii libqt4-dbus 4:4.5.2-2 Qt 4 D-Bus module ii libqt4-network 4:4.5.2-2 Qt 4 network module ii libqt4-svg 4:4.5.2-2 Qt 4 SVG module ii libqt4-xml 4:4.5.2-2 Qt 4 XML module ii libqtcore4 4:4.5.2-2 Qt 4 core module ii libqtgui4 4:4.5.2-2 Qt 4 GUI module ii libstdc++6 4.4.1-4 The GNU Standard C++ Library v3 ii melt 0.4.4-2+b1 command line media player and vide Versions of packages kdenlive recommends: ii dvdauthor 0.6.14-3+b3 create DVD-Video file system ii dvgrab 3.4-1 grab digital video data via IEEE13 ii frei0r-plugins 1.1.22git20090409-2 minimalistic plugin API for video ii genisoimage 9:1.1.9-1 Creates ISO-9660 CD-ROM filesystem pn recordmydesktop <none> (no description available) ii swh-plugins 0.4.15+1-3 Steve Harris's LADSPA plugins kdenlive suggests no packages. - -- no debconf information - -- /* Mit freundlichem Gruß / With kind regards, Patrick Matthäi GNU/Linux Debian Developer E-Mail: [email protected] [email protected] Comment: Always if we think we are right, we were maybe wrong. */ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkq2fbAACgkQ2XA5inpabMe7DgCgpm/FqQf3rdTOnPlY1LtcDdEa B6cAnRDJRPryaug7kiWWw397cOnu0rcc =4Whi -----END PGP SIGNATURE-----
Index: kdenlive-0.7.5/src/dvdwizard.cpp
===================================================================
--- kdenlive-0.7.5.orig/src/dvdwizard.cpp 2009-09-20 13:37:14.000000000 +0200
+++ kdenlive-0.7.5/src/dvdwizard.cpp 2009-09-20 13:37:30.000000000 +0200
@@ -525,7 +525,7 @@
m_mkiso->setProcessChannelMode(QProcess::MergedChannels);
QListWidgetItem *isoitem = m_status.job_progress->item(4);
isoitem->setIcon(KIcon("system-run"));
- m_mkiso->start("mkisofs", args);
+ m_mkiso->start("genisoimage", args);
}
Index: kdenlive-0.7.5/src/dvdwizardvob.cpp
===================================================================
--- kdenlive-0.7.5.orig/src/dvdwizardvob.cpp 2009-09-20 13:38:20.000000000 +0200
+++ kdenlive-0.7.5/src/dvdwizardvob.cpp 2009-09-20 13:39:07.000000000 +0200
@@ -53,7 +53,7 @@
m_view.vobs_list->setIconSize(QSize(60, 45));
if (KStandardDirs::findExe("dvdauthor").isEmpty()) m_errorMessage.append(i18n("<strong>Program %1 is required for the DVD wizard.</strong>", i18n("dvdauthor")));
- if (KStandardDirs::findExe("mkisofs").isEmpty()) m_errorMessage.append(i18n("<strong>Program %1 is required for the DVD wizard.</strong>", i18n("mkisofs")));
+ if (KStandardDirs::findExe("genisoimage").isEmpty()) m_errorMessage.append(i18n("<strong>Program %1 is required for the DVD wizard.</strong>", i18n("genisoimage")));
if (m_errorMessage.isEmpty()) m_view.error_message->setVisible(false);
else m_view.error_message->setText(m_errorMessage);
Index: kdenlive-0.7.5/src/wizard.cpp
===================================================================
--- kdenlive-0.7.5.orig/src/wizard.cpp 2009-09-20 13:37:50.000000000 +0200
+++ kdenlive-0.7.5/src/wizard.cpp 2009-09-20 13:38:08.000000000 +0200
@@ -337,7 +337,7 @@
item = new QTreeWidgetItem(m_check.programList, QStringList() << QString() << i18n("Mkisofs"));
item->setData(1, Qt::UserRole, i18n("Required for creation of DVD ISO images"));
item->setSizeHint(0, itemSize);
- if (KStandardDirs::findExe("mkisofs").isEmpty()) item->setIcon(0, m_badIcon);
+ if (KStandardDirs::findExe("genisoimage").isEmpty()) item->setIcon(0, m_badIcon);
else item->setIcon(0, m_okIcon);
// set up some default applications
switch_to_genisoimage.patch.sig
Description: Binary data
------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf
_______________________________________________ Kdenlive-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kdenlive-devel
