Fixes Coverity CID 709302: Dereference before null check (REVERSE_INULL)
Dereferencing pointer "this->m_render". [show details]
736 int width = (int)(height * m_render->dar());
...
Dereferencing "this->m_render" before a null check.
749 if (m_render == NULL) {
750 kDebug() << "********* ERROR, NULL RENDR";
751 return;
---
src/projectlist.cpp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/projectlist.cpp b/src/projectlist.cpp
index df1ac4f..0397801 100644
--- a/src/projectlist.cpp
+++ b/src/projectlist.cpp
@@ -733,6 +733,10 @@ void ProjectList::slotMissingClip(const QString &id)
if (item) {
item->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled |
Qt::ItemIsDropEnabled);
int height = m_listView->iconSize().height();
+ if (m_render == NULL) {
+ kDebug() << "********* ERROR, NULL RENDR";
+ return;
+ }
int width = (int)(height * m_render->dar());
QPixmap pixmap = qVariantValue<QPixmap>(item->data(0,
Qt::DecorationRole));
if (pixmap.isNull()) {
@@ -746,10 +750,6 @@ void ProjectList::slotMissingClip(const QString &id)
item->setData(0, Qt::DecorationRole, pixmap);
if (item->referencedClip()) {
item->referencedClip()->setPlaceHolder(true);
- if (m_render == NULL) {
- kDebug() << "********* ERROR, NULL RENDR";
- return;
- }
Mlt::Producer *newProd = m_render->invalidProducer(id);
if (item->referencedClip()->getProducer()) {
Mlt::Properties props(newProd->get_properties());
--
1.7.10.4
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Kdenlive-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/kdenlive-devel
