https://bugs.kde.org/show_bug.cgi?id=289084





--- Comment #6 from Luke-Jr <luke-jr+kdebugs utopios org>  2011-12-17 18:32:58 
---
I'm not sure Allen's rewrite will work, unless there's some C++/Qt magic I'm
unaware of... You're starting with a char, adding a QString, then a const
char*. In the original version, as well as my rewrite, everything begins with a
QString, so there is operator+ in effect. Perhaps more importantly, the
original commit that broke this was doing something to enable some QString
optimization, and I suspect this rewrite may break that.

Is there a reason not to just revert this and apply my original, safer patch
with `git am`?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
_______________________________________________
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

Reply via email to