On Fri, 8 Dec 2023 at 23:35, Steve Langasek <2044...@bugs.launchpad.net> wrote:
>
> zfs-linux (2.2.2-0ubuntu1~23.10) mantic; urgency=medium
>
>   * New upstream release. LP: #2044657
>     - Address potential data corruption
>
> I'm assuming the plan for fixing it on earlier releases does not involve
> updating to 2.2.2.
>
> And this does not fall under a hardware enablement exception.  AND there
> are packaging changes under debian/.
>
> The diff for this new upstream release is 9kloc.  I would expect a
> cherry-picked fix here for mantic, not a full upstream backport - just
> as will be required for releases prior to mantic.

My plan was to do updates as follows:
- upgrade to 2.2.2 for mantic
- upgrade to 2.1.14 for jammy (to cover this issue, but also potential
straight line speculation fixes)
- cherry-pick of individual bug fix for focal and earlier

I also do not understand why I ended up maintaining any of zfs-linux
anymore btw. Especially the userspace side of things. I am happy to
SRU just the kernel code changes alone, and let foundations handle the
zfs userspace fixes.

Separately, do note that lxd snap builds and vendors the full multiple
zfs userspace tooling. So i'm not sure there is any stability value in
not taking the full point releases for the userspace tooling changes
in the classic ubuntu release - or try to untangle them.

Regards,

Dimitri.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2044657

Title:
  Multiple data corruption issues in zfs

Status in zfs-linux package in Ubuntu:
  Fix Committed
Status in zfs-linux source package in Xenial:
  Confirmed
Status in zfs-linux source package in Bionic:
  Confirmed
Status in zfs-linux source package in Focal:
  Confirmed
Status in zfs-linux source package in Jammy:
  Confirmed
Status in zfs-linux source package in Lunar:
  Confirmed
Status in zfs-linux source package in Mantic:
  Incomplete
Status in zfs-linux source package in Noble:
  Fix Committed

Bug description:
  [ Impact ]

   * Multiple data corruption issues have been identified and fixed in
  ZFS. Some of them, at varying real-life reproducibility frequency have
  been deterimed to affect very old zfs releases. Recommendation is to
  upgrade to 2.2.2 or 2.1.14 or backport dnat patch alone. This is to
  ensure users get other potentially related fixes and runtime tunables
  to possibly mitigate other bugs that are related and are being fixed
  upstream for future releases.

   * For jammy the 2.1.14 upgrade will bring HWE kernel support and also
  compatiblity/support for hardened kernel builds that mitigate SLS
  (straight-line-speculation).

  [ Test Plan ]

   * !!! Danger !!! use reproducer from
  https://zfsonlinux.topicbox.com/groups/zfs-discuss/T12876116b8607cdb
  and confirm if that issue is resolved or not. Do not run on production
  ZFS pools / systems.

   * autopkgtest pass (from https://ubuntu-archive-
  team.ubuntu.com/proposed-migration/ )

   * adt-matrix pass (from https://kernel.ubuntu.com/adt-matrix/ )

   * kernel regression zfs testsuite pass (from Kernel team RT test
  results summary, private)

   * zsys integration test pass (upgrade of zsys installed systems for
  all releases)

   * zsys install test pass (for daily images of LTS releases only that
  have such installer support, as per iso tracker test case)

   * LXD (ping LXD team to upgrade vendored in tooling to 2.2.2 and
  2.1.14, and test LXD on these updated kernels)

  
  [ Where problems could occur ]

   * Upgrade to 2.1.14 on jammy with SLS mitigations compatiblity will 
introduce slight slow down on amd64 (for hw accelerated assembly code-paths 
only in the encryption primitives)
   
   * Uncertain of the perfomance impact of the extra checks in dnat patch fix 
itself. Possibly affecting speed of operation, at the benefit of correctness.

  [ Other Info ]
   
   * https://github.com/openzfs/zfs/pull/15571 is most current consideration of 
affairs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2044657/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to