On 01/12/2015 01:45 PM, Brian Norris wrote: > CPU arrays (e.g., kgdb_info[]) are indexed from 0 (inclusive) to NR_CPUS > (exclusive). > > Pointed out by Coverity, CID 1262269 > > Signed-off-by: Brian Norris <computersforpe...@gmail.com> > Cc: Jason Wessel <jason.wes...@windriver.com> > --- > Untested > > kernel/debug/kdb/kdb_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c > index f191bddf64b8..53f051853f14 100644 > --- a/kernel/debug/kdb/kdb_main.c > +++ b/kernel/debug/kdb/kdb_main.c > @@ -2256,7 +2256,7 @@ static int kdb_cpu(int argc, const char **argv) > /* > * Validate cpunum > */ > - if ((cpunum > NR_CPUS) || !kgdb_info[cpunum].enter_kgdb) > + if ((cpunum >= NR_CPUS) || !kgdb_info[cpunum].enter_kgdb) > return KDB_BADCPUNUM; > > dbg_switch_cpu = cpunum;
This is actually already fixed a different way in the kgdb-next: https://git.kernel.org/cgit/linux/kernel/git/jwessel/kgdb.git/commit/?h=kgdb-next&id=c7d9ebf81c456dc185c8eae9e293bfdccf2a65f5 diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 8f4bb40..b25eb80 100644 --- a/kernel/debug/kdb/kdb_main.c <https://git.kernel.org/cgit/linux/kernel/git/jwessel/kgdb.git/tree/kernel/debug/kdb/kdb_main.c?h=kgdb-next&id=9705097e962127b07c0aeea64aacd5302126920b> +++ b/kernel/debug/kdb/kdb_main.c <https://git.kernel.org/cgit/linux/kernel/git/jwessel/kgdb.git/tree/kernel/debug/kdb/kdb_main.c?h=kgdb-next&id=c7d9ebf81c456dc185c8eae9e293bfdccf2a65f5> @@ -2256,7 +2256,7 @@ static int kdb_cpu(int argc, const char **argv) /* * Validate cpunum */ - if ((cpunum > NR_CPUS) || !kgdb_info[cpunum].enter_kgdb) + if ((cpunum >= CONFIG_NR_CPUS) || !kgdb_info[cpunum].enter_kgdb) return KDB_BADCPUNUM; dbg_switch_cpu = cpunum; ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. www.gigenet.com _______________________________________________ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
