The suggested sequence is: 1. You notice your stuff for pushed, yay! 2. You look at Jenkins runs for the relevant branches (e.g. Koha_Master_* tasks) 3. If some test gets broken that day, you try too see if it was you. Beware sometimes it is not obvious.
Today there was a failure in the holds API tests, because of a bug that didn't touch the API, but made the code stricter (?) so the loose tests we had written had to be tweaked so they didn't trigger a silly error. So the devs did right, didn't introduce a bug, but made the tests fail. But it is all of us, specially those who got patches pushed, who should be looking after those failures. Team work Thanks! El jue, 2 nov 2023 21:15, David Cook <dc...@prosentient.com.au> escribió: > What’s the best way to do this? > > > > I think Jenkins might send emails, but I think my mail server blocked it > ages ago as spam. > > > > David Cook > > Senior Software Engineer > > Prosentient Systems > > Suite 7.03 > > 6a Glen St > > Milsons Point NSW 2061 > > Australia > > > > Office: 02 9212 0899 > > Online: 02 8005 0595 > > > > *From:* Koha-devel <koha-devel-boun...@lists.koha-community.org> *On > Behalf Of *Tomas Cohen Arazi via Koha-devel > *Sent:* Friday, 3 November 2023 12:31 AM > *To:* koha-devel <koha-devel@lists.koha-community.org> > *Subject:* [Koha-devel] Last month before the release > > > > Hi all. > > > > We are almost done with the release, a couple medium/big things to push > today/tomorrow and then bug fixing. > > > > I wanted to ask y'all to please view the Jenkins tasks status anytime > after your stuff has been pushed. I know I said this many times, but some > devs clearly break some tests that are trivially fixable and the team needs > you to take care of your breakages. > > > > I'm doing my best to track things and fix, but you should all be worried > about that. > > > > -- > > Tomás Cohen Arazi > > Theke Solutions (https://theke.io) > ✆ +54 9351 3513384 > GPG: B2F3C15F >
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/