Maddev from launchpad suggested to use QRegExp because the resulting code is much cleaner and easier to understand. Also there were problems (they weren't able to import anything) for some users when they tried to import their pidgin logs, because pidgin changed its log format at least once. This new QRegExp mechanism is much more resistant against these changes and also against broken pidgin xml-files (e.g. missing close-tags).

What do you think?

Timo

Olivier Goffart wrote:
Le Saturday 20 June 2009, Timo Schlüßler a écrit :
Hi,

as reported on https://bugs.launchpad.net/bugs/378428 there were
problems when importing history logs from pidgin, because of a slightly
different format used by different pidgin versions.

The latest patch posted there (which is also attached to this email)
solves the mentioned problems and should be applied to the kopete source.
Could someone (maybe Olivier Goffart?) of you do this? It would be very
nice if this patch will made it into the first release of KDE 4.3.

Using QTextStream is a good thing.
Byt why can't you use QXmlStreamReader anymore?
You can use QXmlStreamReader::addData to add the decoded data.

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to