> On 2009-05-23 04:15:28, Detlev Casanova wrote:
> > It's a good idea but will only be temporary.
> > Google plans on updating their implementation as soon as the XFS jingle 
> > specifications are accepted by the XMPP council (should be any time soon, 
> > since a long time though).
> 
> Pali Rohár wrote:
>     Will be later libjingle call example application works?
> 
> Detlev Casanova wrote:
>     Yes, it should, but at that time (I hope before feature freeze for kde 
> 4.4) there will be a compatible implementation in libiris.
>     Currently, the spec changes too often to have an implementation which is 
> compatible for all clients.
>     
>     I don't know if Google folks are going to release a new libjingle version 
> and I don't know if it will be compatible.

Can I commit this patch to svn now? Or it is something wrong with this?


- Pali


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/753/#review1182
-----------------------------------------------------------


On 2009-07-21 15:08:07, Pali Rohár wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/753/
> -----------------------------------------------------------
> 
> (Updated 2009-07-21 15:08:07)
> 
> 
> Review request for Kopete.
> 
> 
> Summary
> -------
> 
> This patch add support (for jabber protocol) Google Talk libjingle voice 
> call. It use external libjingle "call" applicaion and stun server from 
> http://code.google.com/p/libjingle/
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdenetwork/kopete/protocols/jabber/CMakeLists.txt 1000543 
>   trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.h 
> PRE-CREATION 
>   trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalk.cpp 
> PRE-CREATION 
>   
> trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.h
>  PRE-CREATION 
>   
> trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.cpp
>  PRE-CREATION 
>   
> trunk/KDE/kdenetwork/kopete/protocols/jabber/googletalk/googletalkcalldialog.ui
>  PRE-CREATION 
>   trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.h 1000543 
>   trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1000543 
>   trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.h 1000543 
>   trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1000543 
> 
> Diff: http://reviewboard.kde.org/r/753/diff
> 
> 
> Testing
> -------
> 
> It works fine with call application from http://code.google.com/p/libjingle/ 
> with patches from http://code.google.com/p/libjingle/issues/list installed in 
> PATH
> 
> I try it with windows version of Google Talk (on windows) and voice call 
> works. I can make call, accept/reject incoming call, hang up call.
> 
> 
> Thanks,
> 
> Pali
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to