On Friday 14 November 2008 08:18:33 Hollis Blanchard wrote: > On Thu, 2008-11-13 at 08:44 +1030, Rusty Russell wrote: > > Note that I still don't have a balloon patch: want to send me one? > > linux: virtio-balloon: avoid implicit use of Linux page size in balloon > interface
Thanks, applied with following diff: Use tabs to indent, and put BUILD_BUG_ON pagesize assumption. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 50e970613233 drivers/virtio/virtio_balloon.c --- a/drivers/virtio/virtio_balloon.c Fri Nov 14 11:40:38 2008 +1030 +++ b/drivers/virtio/virtio_balloon.c Fri Nov 14 11:41:19 2008 +1030 @@ -58,10 +58,11 @@ static u32 page_to_balloon_pfn(struct page *page) { - unsigned long pfn = page_to_pfn(page); + unsigned long pfn = page_to_pfn(page); - /* Convert pfn from Linux page size to balloon page size. */ - return pfn >> (PAGE_SHIFT - VIRTIO_BALLOON_PFN_SHIFT); + BUILD_BUG_ON(PAGE_SHIFT < VIRTIO_BALLOON_PFN_SHIFT); + /* Convert pfn from Linux page size to balloon page size. */ + return pfn >> (PAGE_SHIFT - VIRTIO_BALLOON_PFN_SHIFT); } static void balloon_ack(struct virtqueue *vq) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html