On Tue, Nov 10, 2015 at 05:22:41PM +0100, Paolo Bonzini wrote:
>
>
> On 06/11/2015 01:24, Andrew Jones wrote:
> > Use bash in the makefiles, like we do in the scripts. Without
> > this some platforms using dash fail to execute make targets
> > that use bash-isms.
> >
> > Signed-off-by: Andrew Jones <drjo...@redhat.com>
> > ---
> > Makefile | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index 0d5933474cd8c..3e60b4f8e4a57 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1,4 +1,6 @@
> >
> > +SHELL := /bin/bash
> > +
> > ifeq ($(wildcard config.mak),)
> > $(error run ./configure first. See ./configure -h)
> > endif
> >
>
> Which bash-isms are actually present?
config/config-arm-common.mak has $(RM) $(TEST_DIR)/*.{o,flat,elf,map} ...
I could certainly change that one, and that may be the only one... But,
we require bash for other scripts anyway, so I think requiring make to
use it is reasonable.
Thanks,
drew
>
> Paolo
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
